Skip to content

Commit

Permalink
V4L/DVB (6445): tuner-core: improve comments inside function fe_relea…
Browse files Browse the repository at this point in the history
…se()

Explain who is responsible for freeing analog_demod_priv

Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
  • Loading branch information
Michael Krufky authored and Mauro Carvalho Chehab committed Jan 25, 2008
1 parent af3b0f3 commit 4524c1a
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion drivers/media/video/tuner-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,15 @@ static void fe_release(struct dvb_frontend *fe)
fe->ops.tuner_ops.release(fe);

fe->ops.analog_demod_ops = NULL;
/* DO NOT kfree(t->fe.analog_demod_priv) */

/* DO NOT kfree(fe->analog_demod_priv)
*
* If we are in this function, analog_demod_priv contains a pointer
* to struct tuner *t. This will be kfree'd in tuner_detach().
*
* Otherwise, fe->ops.analog_demod_ops->release will
* handle the cleanup for analog demodulator modules.
*/
fe->analog_demod_priv = NULL;
}

Expand Down

0 comments on commit 4524c1a

Please sign in to comment.