Skip to content

Commit

Permalink
staging: line6: drop amp/effects dump request triggers
Browse files Browse the repository at this point in the history
Since the driver no longer needs to keep state of device parameters it
is no longer necessary to refresh state when messages that affect other
parameters are sent.  Drop the code to trigger a dump when amp/effects
are changed.

Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Stefan Hajnoczi authored and Greg Kroah-Hartman committed Nov 27, 2012
1 parent 9f673d7 commit 4528555
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions drivers/staging/line6/pod.c
Original file line number Diff line number Diff line change
Expand Up @@ -174,12 +174,6 @@ void line6_pod_process_message(struct usb_line6_pod *pod)
/* intentionally no break here! */

case LINE6_PARAM_CHANGE | LINE6_CHANNEL_HOST:
if ((buf[1] == POD_amp_model_setup) ||
(buf[1] == POD_effect_setup))
/* these also affect other settings */
line6_dump_request_async(&pod->dumpreq, &pod->line6, 0,
LINE6_DUMP_CURRENT);

break;

case LINE6_PROGRAM_CHANGE | LINE6_CHANNEL_DEVICE:
Expand Down Expand Up @@ -288,9 +282,6 @@ void line6_pod_transmit_parameter(struct usb_line6_pod *pod, int param,
{
if (line6_transmit_parameter(&pod->line6, param, value) == 0)
pod_store_parameter(pod, param, value);

if ((param == POD_amp_model_setup) || (param == POD_effect_setup)) /* these also affect other settings */
line6_invalidate_current(&pod->dumpreq);
}

/*
Expand Down

0 comments on commit 4528555

Please sign in to comment.