Skip to content

Commit

Permalink
ia64: iosapic: Remove redundant mask from ack()
Browse files Browse the repository at this point in the history
The core code calls mask_ack() which calls irq_ack() and irq_mask()
for the case where an interrupt is disabled and marked pending. That
seems to be a leftover from the old __do_IRQ() mode.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Thomas Gleixner committed Mar 29, 2011
1 parent a217833 commit 459960d
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions arch/ia64/kernel/iosapic.c
Original file line number Diff line number Diff line change
Expand Up @@ -450,18 +450,9 @@ static void
iosapic_ack_edge_irq (struct irq_data *data)
{
unsigned int irq = data->irq;
struct irq_desc *idesc = irq_desc + irq;

irq_complete_move(irq);
move_native_irq(irq);
/*
* Once we have recorded IRQ_PENDING already, we can mask the
* interrupt for real. This prevents IRQ storms from unhandled
* devices.
*/
if ((idesc->status & (IRQ_PENDING|IRQ_DISABLED)) ==
(IRQ_PENDING|IRQ_DISABLED))
mask_irq(data);
}

#define iosapic_enable_edge_irq unmask_irq
Expand Down

0 comments on commit 459960d

Please sign in to comment.