Skip to content

Commit

Permalink
powerpc/PCI: convert to pci_create_root_bus()
Browse files Browse the repository at this point in the history
Convert from pci_create_bus() to pci_create_root_bus().  This way the root
bus resources are correct immediately.  This patch doesn't fix a problem
because powerpc fixed the resources before scanning the bus, but it makes
powerpc more consistent with other architectures.

v2: fix build error with resource pointer passing

CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
  • Loading branch information
Bjorn Helgaas authored and Jesse Barnes committed Jan 6, 2012
1 parent 49a6cba commit 45a709f
Showing 1 changed file with 14 additions and 11 deletions.
25 changes: 14 additions & 11 deletions arch/powerpc/kernel/pci-common.c
Original file line number Diff line number Diff line change
Expand Up @@ -1560,14 +1560,13 @@ int pcibios_enable_device(struct pci_dev *dev, int mask)
return pci_enable_resources(dev, mask);
}

static void __devinit pcibios_setup_phb_resources(struct pci_controller *hose)
static void __devinit pcibios_setup_phb_resources(struct pci_controller *hose, struct list_head *resources)
{
struct pci_bus *bus = hose->bus;
struct resource *res;
int i;

/* Hookup PHB IO resource */
bus->resource[0] = res = &hose->io_resource;
res = &hose->io_resource;

if (!res->flags) {
printk(KERN_WARNING "PCI: I/O resource not set for host"
Expand All @@ -1585,6 +1584,7 @@ static void __devinit pcibios_setup_phb_resources(struct pci_controller *hose)
(unsigned long long)res->start,
(unsigned long long)res->end,
(unsigned long)res->flags);
pci_add_resource(resources, res);

/* Hookup PHB Memory resources */
for (i = 0; i < 3; ++i) {
Expand All @@ -1602,12 +1602,12 @@ static void __devinit pcibios_setup_phb_resources(struct pci_controller *hose)
res->flags = IORESOURCE_MEM;
#endif /* CONFIG_PPC32 */
}
bus->resource[i+1] = res;

pr_debug("PCI: PHB MEM resource %d = %016llx-%016llx [%lx]\n", i,
(unsigned long long)res->start,
(unsigned long long)res->end,
(unsigned long)res->flags);
pci_add_resource(resources, res);
}

pr_debug("PCI: PHB MEM offset = %016llx\n",
Expand Down Expand Up @@ -1701,29 +1701,32 @@ struct device_node *pcibios_get_phb_of_node(struct pci_bus *bus)
*/
void __devinit pcibios_scan_phb(struct pci_controller *hose)
{
LIST_HEAD(resources);
struct pci_bus *bus;
struct device_node *node = hose->dn;
int mode;

pr_debug("PCI: Scanning PHB %s\n",
node ? node->full_name : "<NO NAME>");

/* Get some IO space for the new PHB */
pcibios_setup_phb_io_space(hose);

/* Wire up PHB bus resources */
pcibios_setup_phb_resources(hose, &resources);

/* Create an empty bus for the toplevel */
bus = pci_create_bus(hose->parent, hose->first_busno, hose->ops, hose);
bus = pci_create_root_bus(hose->parent, hose->first_busno,
hose->ops, hose, &resources);
if (bus == NULL) {
pr_err("Failed to create bus for PCI domain %04x\n",
hose->global_number);
pci_free_resource_list(&resources);
return;
}
bus->secondary = hose->first_busno;
hose->bus = bus;

/* Get some IO space for the new PHB */
pcibios_setup_phb_io_space(hose);

/* Wire up PHB bus resources */
pcibios_setup_phb_resources(hose);

/* Get probe mode and perform scan */
mode = PCI_PROBE_NORMAL;
if (node && ppc_md.pci_probe_mode)
Expand Down

0 comments on commit 45a709f

Please sign in to comment.