Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 284897
b: refs/heads/master
c: 714ad3a
h: refs/heads/master
i:
  284895: b561464
v: v3
  • Loading branch information
Tomi Valkeinen committed Dec 2, 2011
1 parent b953ef0 commit 45c8910
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 26 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 8754595796a45e88411b68005bc98310c8c6ae76
refs/heads/master: 714ad3ac505bba711f961bb8013644c9d8fb486a
26 changes: 1 addition & 25 deletions trunk/drivers/video/omap2/dss/manager.c
Original file line number Diff line number Diff line change
Expand Up @@ -1313,8 +1313,6 @@ static int omap_dss_mgr_apply(struct omap_overlay_manager *mgr)
struct manager_cache_data *mc;
int i;
struct omap_overlay *ovl;
int num_planes_enabled = 0;
bool use_fifomerge;
unsigned long flags;
int r;

Expand Down Expand Up @@ -1347,11 +1345,8 @@ static int omap_dss_mgr_apply(struct omap_overlay_manager *mgr)
continue;
}

if (!ovl->info_dirty) {
if (oc->enabled)
++num_planes_enabled;
if (!ovl->info_dirty)
continue;
}

dssdev = ovl->manager->device;

Expand All @@ -1375,8 +1370,6 @@ static int omap_dss_mgr_apply(struct omap_overlay_manager *mgr)
oc->channel = ovl->manager->id;

oc->enabled = true;

++num_planes_enabled;
}

/* Configure managers */
Expand Down Expand Up @@ -1406,21 +1399,6 @@ static int omap_dss_mgr_apply(struct omap_overlay_manager *mgr)
dssdev->caps & OMAP_DSS_DISPLAY_CAP_MANUAL_UPDATE;
}

/* XXX TODO: Try to get fifomerge working. The problem is that it
* affects both managers, not individually but at the same time. This
* means the change has to be well synchronized. I guess the proper way
* is to have a two step process for fifo merge:
* fifomerge enable:
* 1. disable other planes, leaving one plane enabled
* 2. wait until the planes are disabled on HW
* 3. config merged fifo thresholds, enable fifomerge
* fifomerge disable:
* 1. config unmerged fifo thresholds, disable fifomerge
* 2. wait until fifo changes are in HW
* 3. enable planes
*/
use_fifomerge = false;

/* Configure overlay fifos */
for (i = 0; i < omap_dss_get_num_overlays(); ++i) {
struct omap_dss_device *dssdev;
Expand All @@ -1436,8 +1414,6 @@ static int omap_dss_mgr_apply(struct omap_overlay_manager *mgr)
dssdev = ovl->manager->device;

size = dispc_ovl_get_fifo_size(ovl->id);
if (use_fifomerge)
size *= 3;

burst_size = dispc_ovl_get_burst_size(ovl->id);

Expand Down

0 comments on commit 45c8910

Please sign in to comment.