Skip to content

Commit

Permalink
Input: uinput - remove BKL from uinput_open function
Browse files Browse the repository at this point in the history
Commit 8702965 pushed down the BKL
into uinput open function. However, there's nothing that needs locking
in there.

Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
  • Loading branch information
Thadeu Lima de Souza Cascardo authored and Dmitry Torokhov committed Jan 30, 2010
1 parent dcfc32b commit 45cdba4
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/input/misc/uinput.c
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
#include <linux/slab.h>
#include <linux/module.h>
#include <linux/init.h>
#include <linux/smp_lock.h>
#include <linux/fs.h>
#include <linux/miscdevice.h>
#include <linux/uinput.h>
Expand Down Expand Up @@ -284,15 +283,13 @@ static int uinput_open(struct inode *inode, struct file *file)
if (!newdev)
return -ENOMEM;

lock_kernel();
mutex_init(&newdev->mutex);
spin_lock_init(&newdev->requests_lock);
init_waitqueue_head(&newdev->requests_waitq);
init_waitqueue_head(&newdev->waitq);
newdev->state = UIST_NEW_DEVICE;

file->private_data = newdev;
unlock_kernel();

return 0;
}
Expand Down

0 comments on commit 45cdba4

Please sign in to comment.