Skip to content

Commit

Permalink
fs/ext3/balloc.c: delete useless initialization
Browse files Browse the repository at this point in the history
Delete nontrivial initialization that is immediately overwritten by the
result of an allocation function.

The semantic match that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
type T;
identifier i;
expression e;
@@

(
T i = \(0\|NULL\|ERR_PTR(...)\);
|
-T i = e;
+T i;
)
... when != i
i = \(kzalloc\|kcalloc\|kmalloc\)(...);

// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Jan Kara <jack@suse.cz>
  • Loading branch information
Julia Lawall authored and Jan Kara committed Aug 17, 2011
1 parent 6e3d6ca commit 4613022
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/ext3/balloc.c
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,7 @@ static inline int rsv_is_empty(struct ext3_reserve_window *rsv)
void ext3_init_block_alloc_info(struct inode *inode)
{
struct ext3_inode_info *ei = EXT3_I(inode);
struct ext3_block_alloc_info *block_i = ei->i_block_alloc_info;
struct ext3_block_alloc_info *block_i;
struct super_block *sb = inode->i_sb;

block_i = kmalloc(sizeof(*block_i), GFP_NOFS);
Expand Down

0 comments on commit 4613022

Please sign in to comment.