Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 318048
b: refs/heads/master
c: caeb249
h: refs/heads/master
v: v3
  • Loading branch information
H Hartley Sweeten authored and Greg Kroah-Hartman committed Jul 19, 2012
1 parent 72019d9 commit 4613ad2
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 9 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 8f9c5b7032df0210c464a0fbb9a93654310da54a
refs/heads/master: caeb2490e046909fcb2f8209b88458a147011819
19 changes: 11 additions & 8 deletions trunk/drivers/staging/comedi/drivers/adl_pci7296.c
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ Configuration Options:

struct adl_pci7296_private {
int data;
struct pci_dev *pci_dev;
};

#define devpriv ((struct adl_pci7296_private *)dev->private)
Expand Down Expand Up @@ -82,6 +81,7 @@ static struct pci_dev *adl_pci7296_find_pci(struct comedi_device *dev,
static int adl_pci7296_attach(struct comedi_device *dev,
struct comedi_devconfig *it)
{
struct pci_dev *pcidev;
struct comedi_subdevice *s;
int ret;

Expand All @@ -96,18 +96,19 @@ static int adl_pci7296_attach(struct comedi_device *dev,
if (ret)
return ret;

devpriv->pci_dev = adl_pci7296_find_pci(dev, it);
if (!devpriv->pci_dev)
pcidev = adl_pci7296_find_pci(dev, it);
if (!pcidev)
return -EIO;
comedi_set_hw_dev(dev, &pcidev->dev);

if (comedi_pci_enable(devpriv->pci_dev, "adl_pci7296") < 0) {
if (comedi_pci_enable(pcidev, "adl_pci7296") < 0) {
printk(KERN_ERR
"comedi%d: Failed to enable PCI device and request regions\n",
dev->minor);
return -EIO;
}

dev->iobase = pci_resource_start(devpriv->pci_dev, 2);
dev->iobase = pci_resource_start(pcidev, 2);
printk(KERN_INFO "comedi: base addr %4lx\n", dev->iobase);

/* four 8255 digital io subdevices */
Expand Down Expand Up @@ -139,10 +140,12 @@ static int adl_pci7296_attach(struct comedi_device *dev,

static void adl_pci7296_detach(struct comedi_device *dev)
{
if (devpriv && devpriv->pci_dev) {
struct pci_dev *pcidev = comedi_to_pci_dev(dev);

if (pcidev) {
if (dev->iobase)
comedi_pci_disable(devpriv->pci_dev);
pci_dev_put(devpriv->pci_dev);
comedi_pci_disable(pcidev);
pci_dev_put(pcidev);
}
if (dev->subdevices) {
subdev_8255_cleanup(dev, dev->subdevices + 0);
Expand Down

0 comments on commit 4613ad2

Please sign in to comment.