Skip to content

Commit

Permalink
staging:iio:ad7887: Do not return error code in interrupt handler
Browse files Browse the repository at this point in the history
The interrupt handler should only ever return one of the three irqreturn_t
constants and not an error code. Also make sure to always call
iio_trigger_notify_done before leaving the trigger handler.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
  • Loading branch information
Lars-Peter Clausen authored and Jonathan Cameron committed Jul 8, 2012
1 parent 9c586a4 commit 46b2495
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/staging/iio/adc/ad7887_ring.c
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ static irqreturn_t ad7887_trigger_handler(int irq, void *p)

buf = kzalloc(indio_dev->scan_bytes, GFP_KERNEL);
if (buf == NULL)
return -ENOMEM;
goto done;

b_sent = spi_sync(st->spi, st->ring_msg);
if (b_sent)
Expand Down

0 comments on commit 46b2495

Please sign in to comment.