Skip to content

Commit

Permalink
rtl8187: Remove pointless check in rtl8187_rx_cb().
Browse files Browse the repository at this point in the history
First of all, it exposes the SKB list implementation.

Second of all it's not needed.  If we get called here, we
successfully enqueued the URB with the linked SKB and
such a completion only gets called one time on such an
SKB.

Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David S. Miller committed May 28, 2009
1 parent a1091aa commit 46c3767
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions drivers/net/wireless/rtl818x/rtl8187_dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -321,12 +321,7 @@ static void rtl8187_rx_cb(struct urb *urb)
unsigned long f;

spin_lock_irqsave(&priv->rx_queue.lock, f);
if (skb->next)
__skb_unlink(skb, &priv->rx_queue);
else {
spin_unlock_irqrestore(&priv->rx_queue.lock, f);
return;
}
__skb_unlink(skb, &priv->rx_queue);
spin_unlock_irqrestore(&priv->rx_queue.lock, f);
skb_put(skb, urb->actual_length);

Expand Down

0 comments on commit 46c3767

Please sign in to comment.