Skip to content

Commit

Permalink
[ARM] shark: avoid polluting the kernel's namespace
Browse files Browse the repository at this point in the history
Avoid unnecessarily pollution of the kernel's namespace by avoiding
mach/hardware.h in mach/io.h.  Include this header file where necessary.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
  • Loading branch information
Russell King authored and Russell King committed Nov 28, 2008
1 parent 514161b commit 47190a3
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 25 deletions.
2 changes: 2 additions & 0 deletions arch/arm/mach-shark/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
#include <asm/leds.h>
#include <asm/param.h>

#include <mach/hardware.h>

#include <asm/mach/map.h>
#include <asm/mach/arch.h>
#include <asm/mach/time.h>
Expand Down
2 changes: 0 additions & 2 deletions arch/arm/mach-shark/include/mach/hardware.h
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@
#define ROMCARD_SIZE 0x08000000
#define ROMCARD_START 0x10000000

#define PCIO_BASE 0xe0000000


/* defines for the Framebuffer */
#define FB_START 0x06000000
Expand Down
27 changes: 4 additions & 23 deletions arch/arm/mach-shark/include/mach/io.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,29 +11,10 @@
#ifndef __ASM_ARM_ARCH_IO_H
#define __ASM_ARM_ARCH_IO_H

#include <mach/hardware.h>
#define PCIO_BASE 0xe0000000
#define IO_SPACE_LIMIT 0xffffffff

#define IO_SPACE_LIMIT 0xffffffff

/*
* We use two different types of addressing - PC style addresses, and ARM
* addresses. PC style accesses the PC hardware with the normal PC IO
* addresses, eg 0x3f8 for serial#1. ARM addresses are 0x80000000+
* and are translated to the start of IO.
*/
#define __PORT_PCIO(x) (!((x) & 0x80000000))

#define __io(a) ((void __iomem *)(PCIO_BASE + (a)))


static inline unsigned int __ioaddr (unsigned int port) \
{ \
if (__PORT_PCIO(port)) \
return (unsigned int)(PCIO_BASE + (port)); \
else \
return (unsigned int)(IO_BASE + (port)); \
}

#define __mem_pci(addr) (addr)
#define __io(a) ((void __iomem *)(PCIO_BASE + (a)))
#define __mem_pci(addr) (addr)

#endif

0 comments on commit 47190a3

Please sign in to comment.