Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 250791
b: refs/heads/master
c: 1c99042
h: refs/heads/master
i:
  250789: 0ac26f3
  250787: b0ff072
  250783: 06f1916
v: v3
  • Loading branch information
Andi Kleen authored and Eric Paris committed Apr 25, 2011
1 parent 7d9a0bb commit 471b4bc
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 9 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 6b697323a78bed254ee372f71b1a6a2901bb4b7a
refs/heads/master: 1c9904297451f558191e211a48d8838b4bf792b0
2 changes: 1 addition & 1 deletion trunk/include/linux/security.h
Original file line number Diff line number Diff line change
Expand Up @@ -1454,7 +1454,7 @@ struct security_operations {
struct inode *new_dir, struct dentry *new_dentry);
int (*inode_readlink) (struct dentry *dentry);
int (*inode_follow_link) (struct dentry *dentry, struct nameidata *nd);
int (*inode_permission) (struct inode *inode, int mask);
int (*inode_permission) (struct inode *inode, int mask, unsigned flags);
int (*inode_setattr) (struct dentry *dentry, struct iattr *attr);
int (*inode_getattr) (struct vfsmount *mnt, struct dentry *dentry);
int (*inode_setxattr) (struct dentry *dentry, const char *name,
Expand Down
2 changes: 1 addition & 1 deletion trunk/security/capability.c
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ static int cap_inode_follow_link(struct dentry *dentry,
return 0;
}

static int cap_inode_permission(struct inode *inode, int mask)
static int cap_inode_permission(struct inode *inode, int mask, unsigned flags)
{
return 0;
}
Expand Down
6 changes: 2 additions & 4 deletions trunk/security/security.c
Original file line number Diff line number Diff line change
Expand Up @@ -514,16 +514,14 @@ int security_inode_permission(struct inode *inode, int mask)
{
if (unlikely(IS_PRIVATE(inode)))
return 0;
return security_ops->inode_permission(inode, mask);
return security_ops->inode_permission(inode, mask, 0);
}

int security_inode_exec_permission(struct inode *inode, unsigned int flags)
{
if (unlikely(IS_PRIVATE(inode)))
return 0;
if (flags)
return -ECHILD;
return security_ops->inode_permission(inode, MAY_EXEC);
return security_ops->inode_permission(inode, MAY_EXEC, flags);
}

int security_inode_setattr(struct dentry *dentry, struct iattr *attr)
Expand Down
6 changes: 5 additions & 1 deletion trunk/security/selinux/hooks.c
Original file line number Diff line number Diff line change
Expand Up @@ -2635,7 +2635,7 @@ static int selinux_inode_follow_link(struct dentry *dentry, struct nameidata *na
return dentry_has_perm(cred, NULL, dentry, FILE__READ);
}

static int selinux_inode_permission(struct inode *inode, int mask)
static int selinux_inode_permission(struct inode *inode, int mask, unsigned flags)
{
const struct cred *cred = current_cred();
struct common_audit_data ad;
Expand All @@ -2649,6 +2649,10 @@ static int selinux_inode_permission(struct inode *inode, int mask)
if (!mask)
return 0;

/* May be droppable after audit */
if (flags & IPERM_FLAG_RCU)
return -ECHILD;

COMMON_AUDIT_DATA_INIT(&ad, FS);
ad.u.fs.inode = inode;

Expand Down
6 changes: 5 additions & 1 deletion trunk/security/smack/smack_lsm.c
Original file line number Diff line number Diff line change
Expand Up @@ -686,7 +686,7 @@ static int smack_inode_rename(struct inode *old_inode,
*
* Returns 0 if access is permitted, -EACCES otherwise
*/
static int smack_inode_permission(struct inode *inode, int mask)
static int smack_inode_permission(struct inode *inode, int mask, unsigned flags)
{
struct smk_audit_info ad;

Expand All @@ -696,6 +696,10 @@ static int smack_inode_permission(struct inode *inode, int mask)
*/
if (mask == 0)
return 0;

/* May be droppable after audit */
if (flags & IPERM_FLAG_RCU)
return -ECHILD;
smk_ad_init(&ad, __func__, LSM_AUDIT_DATA_FS);
smk_ad_setfield_u_fs_inode(&ad, inode);
return smk_curacc(smk_of_inode(inode), mask, &ad);
Expand Down

0 comments on commit 471b4bc

Please sign in to comment.