Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 125694
b: refs/heads/master
c: 4462344
h: refs/heads/master
v: v3
  • Loading branch information
Rusty Russell committed Dec 31, 2008
1 parent fad934c commit 4724e15
Show file tree
Hide file tree
Showing 7 changed files with 17 additions and 11 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 9e01c1b74c9531e301c900edaa92a99fcb7738f2
refs/heads/master: 4462344ee9ea9224d026801b877887f2f39774a3
12 changes: 9 additions & 3 deletions trunk/kernel/trace/trace.c
Original file line number Diff line number Diff line change
Expand Up @@ -1811,10 +1811,10 @@ static void test_cpu_buff_start(struct trace_iterator *iter)
if (!(iter->iter_flags & TRACE_FILE_ANNOTATE))
return;

if (cpu_isset(iter->cpu, iter->started))
if (cpumask_test_cpu(iter->cpu, iter->started))
return;

cpu_set(iter->cpu, iter->started);
cpumask_set_cpu(iter->cpu, iter->started);
trace_seq_printf(s, "##### CPU %u buffer started ####\n", iter->cpu);
}

Expand Down Expand Up @@ -3114,10 +3114,15 @@ static int tracing_open_pipe(struct inode *inode, struct file *filp)
if (!iter)
return -ENOMEM;

if (!alloc_cpumask_var(&iter->started, GFP_KERNEL)) {
kfree(iter);
return -ENOMEM;
}

mutex_lock(&trace_types_lock);

/* trace pipe does not show start of buffer */
cpus_setall(iter->started);
cpumask_setall(iter->started);

iter->tr = &global_trace;
iter->trace = current_trace;
Expand All @@ -3134,6 +3139,7 @@ static int tracing_release_pipe(struct inode *inode, struct file *file)
{
struct trace_iterator *iter = file->private_data;

free_cpumask_var(iter->started);
kfree(iter);
atomic_dec(&tracing_reader);

Expand Down
2 changes: 1 addition & 1 deletion trunk/kernel/trace/trace.h
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ struct trace_iterator {
loff_t pos;
long idx;

cpumask_t started;
cpumask_var_t started;
};

int tracing_is_enabled(void);
Expand Down
2 changes: 1 addition & 1 deletion trunk/kernel/trace/trace_boot.c
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ static int boot_trace_init(struct trace_array *tr)
int cpu;
boot_trace = tr;

for_each_cpu_mask(cpu, cpu_possible_map)
for_each_cpu(cpu, cpu_possible_mask)
tracing_reset(tr, cpu);

tracing_sched_switch_assign_trace(tr);
Expand Down
2 changes: 1 addition & 1 deletion trunk/kernel/trace/trace_functions_graph.c
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ print_graph_cpu(struct trace_seq *s, int cpu)
int i;
int ret;
int log10_this = log10_cpu(cpu);
int log10_all = log10_cpu(cpus_weight_nr(cpu_online_map));
int log10_all = log10_cpu(cpumask_weight(cpu_online_mask));


/*
Expand Down
6 changes: 3 additions & 3 deletions trunk/kernel/trace/trace_hw_branches.c
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ static void bts_trace_start(struct trace_array *tr)

tracing_reset_online_cpus(tr);

for_each_cpu_mask(cpu, cpu_possible_map)
for_each_cpu(cpu, cpu_possible_mask)
smp_call_function_single(cpu, bts_trace_start_cpu, NULL, 1);
}

Expand All @@ -62,7 +62,7 @@ static void bts_trace_stop(struct trace_array *tr)
{
int cpu;

for_each_cpu_mask(cpu, cpu_possible_map)
for_each_cpu(cpu, cpu_possible_mask)
smp_call_function_single(cpu, bts_trace_stop_cpu, NULL, 1);
}

Expand Down Expand Up @@ -172,7 +172,7 @@ static void trace_bts_prepare(struct trace_iterator *iter)
{
int cpu;

for_each_cpu_mask(cpu, cpu_possible_map)
for_each_cpu(cpu, cpu_possible_mask)
smp_call_function_single(cpu, trace_bts_cpu, iter->tr, 1);
}

Expand Down
2 changes: 1 addition & 1 deletion trunk/kernel/trace/trace_power.c
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ static int power_trace_init(struct trace_array *tr)

trace_power_enabled = 1;

for_each_cpu_mask(cpu, cpu_possible_map)
for_each_cpu(cpu, cpu_possible_mask)
tracing_reset(tr, cpu);
return 0;
}
Expand Down

0 comments on commit 4724e15

Please sign in to comment.