Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 315979
b: refs/heads/master
c: 06ce97d
h: refs/heads/master
i:
  315977: 784a337
  315975: 59b520a
v: v3
  • Loading branch information
Guenter Roeck committed Jul 22, 2012
1 parent 3cf8e9b commit 472c91a
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 12 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 4cb14a3a6545bf4c51d6b61b95ccc1afe59510c9
refs/heads/master: 06ce97d608fb0599509c1c586662ba4778719fc4
18 changes: 7 additions & 11 deletions trunk/drivers/hwmon/adm1021.c
Original file line number Diff line number Diff line change
Expand Up @@ -366,11 +366,11 @@ static int adm1021_probe(struct i2c_client *client,
struct adm1021_data *data;
int err;

data = kzalloc(sizeof(struct adm1021_data), GFP_KERNEL);
data = devm_kzalloc(&client->dev, sizeof(struct adm1021_data),
GFP_KERNEL);
if (!data) {
pr_debug("adm1021: detect failed, kzalloc failed!\n");
err = -ENOMEM;
goto error0;
pr_debug("adm1021: detect failed, devm_kzalloc failed!\n");
return -ENOMEM;
}

i2c_set_clientdata(client, data);
Expand All @@ -384,21 +384,18 @@ static int adm1021_probe(struct i2c_client *client,
/* Register sysfs hooks */
err = sysfs_create_group(&client->dev.kobj, &adm1021_group);
if (err)
goto error1;
return err;

data->hwmon_dev = hwmon_device_register(&client->dev);
if (IS_ERR(data->hwmon_dev)) {
err = PTR_ERR(data->hwmon_dev);
goto error3;
goto error;
}

return 0;

error3:
error:
sysfs_remove_group(&client->dev.kobj, &adm1021_group);
error1:
kfree(data);
error0:
return err;
}

Expand All @@ -418,7 +415,6 @@ static int adm1021_remove(struct i2c_client *client)
hwmon_device_unregister(data->hwmon_dev);
sysfs_remove_group(&client->dev.kobj, &adm1021_group);

kfree(data);
return 0;
}

Expand Down

0 comments on commit 472c91a

Please sign in to comment.