Skip to content

Commit

Permalink
rtc: convert wm8350 use new alarm and update operations
Browse files Browse the repository at this point in the history
These are the only two ioctls so the ioctl() function is also removed.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Acked-by: Alessandro Zummo <a.zummo@towertech.it>
Cc: David Brownell <david-b@pacbell.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Mark Brown authored and Linus Torvalds committed Apr 1, 2009
1 parent 7995589 commit 47367a3
Showing 1 changed file with 18 additions and 21 deletions.
39 changes: 18 additions & 21 deletions drivers/rtc/rtc-wm8350.c
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,17 @@ static int wm8350_rtc_start_alarm(struct wm8350 *wm8350)
return 0;
}

static int wm8350_rtc_alarm_irq_enable(struct device *dev,
unsigned int enabled)
{
struct wm8350 *wm8350 = dev_get_drvdata(dev);

if (enabled)
return wm8350_rtc_start_alarm(wm8350);
else
return wm8350_rtc_stop_alarm(wm8350);
}

static int wm8350_rtc_setalarm(struct device *dev, struct rtc_wkalrm *alrm)
{
struct wm8350 *wm8350 = dev_get_drvdata(dev);
Expand Down Expand Up @@ -291,30 +302,15 @@ static int wm8350_rtc_setalarm(struct device *dev, struct rtc_wkalrm *alrm)
return ret;
}

/*
* Handle commands from user-space
*/
static int wm8350_rtc_ioctl(struct device *dev, unsigned int cmd,
unsigned long arg)
static int wm8350_rtc_update_irq_enable(struct device *dev,
unsigned int enabled)
{
struct wm8350 *wm8350 = dev_get_drvdata(dev);

switch (cmd) {
case RTC_AIE_OFF:
return wm8350_rtc_stop_alarm(wm8350);
case RTC_AIE_ON:
return wm8350_rtc_start_alarm(wm8350);

case RTC_UIE_OFF:
wm8350_mask_irq(wm8350, WM8350_IRQ_RTC_SEC);
break;
case RTC_UIE_ON:
if (enabled)
wm8350_unmask_irq(wm8350, WM8350_IRQ_RTC_SEC);
break;

default:
return -ENOIOCTLCMD;
}
else
wm8350_mask_irq(wm8350, WM8350_IRQ_RTC_SEC);

return 0;
}
Expand Down Expand Up @@ -345,11 +341,12 @@ static void wm8350_rtc_update_handler(struct wm8350 *wm8350, int irq,
}

static const struct rtc_class_ops wm8350_rtc_ops = {
.ioctl = wm8350_rtc_ioctl,
.read_time = wm8350_rtc_readtime,
.set_time = wm8350_rtc_settime,
.read_alarm = wm8350_rtc_readalarm,
.set_alarm = wm8350_rtc_setalarm,
.alarm_irq_enable = wm8350_rtc_alarm_irq_enable,
.update_irq_enable = wm8350_rtc_update_irq_enable,
};

#ifdef CONFIG_PM
Expand Down

0 comments on commit 47367a3

Please sign in to comment.