Skip to content

Commit

Permalink
bridge: Use rcu_barrier() instead of syncronize_net() on unload.
Browse files Browse the repository at this point in the history
When unloading modules that uses call_rcu() callbacks, then we must
use rcu_barrier().  This module uses syncronize_net() which is not
enough to be sure that all callback has been completed.

Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jesper Dangaard Brouer authored and David S. Miller committed Jun 26, 2009
1 parent 1f2ccd0 commit 473c22d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/bridge/br.c
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ static void __exit br_deinit(void)

unregister_pernet_subsys(&br_net_ops);

synchronize_net();
rcu_barrier(); /* Wait for completion of call_rcu()'s */

br_netfilter_fini();
#if defined(CONFIG_ATM_LANE) || defined(CONFIG_ATM_LANE_MODULE)
Expand Down

0 comments on commit 473c22d

Please sign in to comment.