Skip to content

Commit

Permalink
cfq-iosched: no dispatch limit for single queue
Browse files Browse the repository at this point in the history
Since commit 2f5cb73, each queue can send
up to 4 * 4 requests if only one queue exists. I wonder why we have such limit.
Device supports tag can send more requests. For example, AHCI can send 31
requests. Test (direct aio randread) shows the limits reduce about 4% disk
thoughput.
On the other hand, since we send one request one time, if other queue
pop when current is sending more than cfq_quantum requests, current queue will
stop send requests soon after one request, so sounds there is no big latency.

Signed-off-by: Shaohua Li <shaohua.li@intel.com>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
  • Loading branch information
Shaohua Li authored and Jens Axboe committed Dec 3, 2009
1 parent 98262f2 commit 474b18c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions block/cfq-iosched.c
Original file line number Diff line number Diff line change
Expand Up @@ -1618,9 +1618,9 @@ static bool cfq_may_dispatch(struct cfq_data *cfqd, struct cfq_queue *cfqq)
return false;

/*
* Sole queue user, allow bigger slice
* Sole queue user, no limit
*/
max_dispatch *= 4;
max_dispatch = -1;
}

/*
Expand Down

0 comments on commit 474b18c

Please sign in to comment.