Skip to content

Commit

Permalink
svcrdma: Shrink scope of spinlock on RQ CQ
Browse files Browse the repository at this point in the history
The rq_cq_reap function is only called from the dto_tasklet. The
only resource shared with other threads is the sc_rq_dto_q. Move the
spin lock to protect only this list.

Signed-off-by: Tom Tucker <tom@opengridcomputing.com>
  • Loading branch information
Tom Tucker committed May 19, 2008
1 parent 8740767 commit 47698e0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions net/sunrpc/xprtrdma/svc_rdma_transport.c
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,6 @@ static void rq_cq_reap(struct svcxprt_rdma *xprt)
ib_req_notify_cq(xprt->sc_rq_cq, IB_CQ_NEXT_COMP);
atomic_inc(&rdma_stat_rq_poll);

spin_lock_bh(&xprt->sc_rq_dto_lock);
while ((ret = ib_poll_cq(xprt->sc_rq_cq, 1, &wc)) > 0) {
ctxt = (struct svc_rdma_op_ctxt *)(unsigned long)wc.wr_id;
ctxt->wc_status = wc.status;
Expand All @@ -303,9 +302,10 @@ static void rq_cq_reap(struct svcxprt_rdma *xprt)
svc_rdma_put_context(ctxt, 1);
continue;
}
spin_lock_bh(&xprt->sc_rq_dto_lock);
list_add_tail(&ctxt->dto_q, &xprt->sc_rq_dto_q);
spin_unlock_bh(&xprt->sc_rq_dto_lock);
}
spin_unlock_bh(&xprt->sc_rq_dto_lock);

if (ctxt)
atomic_inc(&rdma_stat_rq_prod);
Expand Down

0 comments on commit 47698e0

Please sign in to comment.