Skip to content

Commit

Permalink
[XFS] Fix nused counter. It's currently getting set to -1 rather than
Browse files Browse the repository at this point in the history
getting decremented by 1.  Since nused never reaches 0, the "if
(!free->hdr.nused)" check in xfs_dir2_leafn_remove() fails every time and
xfs_dir2_shrink_inode() doesn't get called when it should.  This causes
extra blocks to be left on an empty directory and the directory in unable
to be converted back to inline extent mode.

SGI-PV: 951958
SGI-Modid: xfs-linux-melb:xfs-kern:211382a

Signed-off-by: Mandy Kirkconnell <alkirkco@sgi.com>
Signed-off-by: Nathan Scott <nathans@sgi.com>
  • Loading branch information
Mandy Kirkconnell authored and Nathan Scott committed Jun 9, 2006
1 parent 421ad13 commit 477829e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/xfs/xfs_dir2_node.c
Original file line number Diff line number Diff line change
Expand Up @@ -972,7 +972,7 @@ xfs_dir2_leafn_remove(
/*
* One less used entry in the free table.
*/
free->hdr.nused = cpu_to_be32(-1);
be32_add(&free->hdr.nused, -1);
xfs_dir2_free_log_header(tp, fbp);
/*
* If this was the last entry in the table, we can
Expand Down

0 comments on commit 477829e

Please sign in to comment.