Skip to content

Commit

Permalink
drm: Fix hashtab implementation leaking illegal error codes to user s…
Browse files Browse the repository at this point in the history
…pace.

reported by Dave Airlie

Signed-off-by: Dave Airlie <airlied@linux.ie>
  • Loading branch information
Thomas Hellstrom authored and Dave Airlie committed Sep 21, 2006
1 parent 9b1a51b commit 47cc140
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/char/drm/drm_hashtab.c
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ int drm_ht_insert_item(drm_open_hash_t *ht, drm_hash_item_t *item)
hlist_for_each(list, h_list) {
entry = hlist_entry(list, drm_hash_item_t, head);
if (entry->key == key)
return -1;
return -EINVAL;
if (entry->key > key)
break;
parent = list;
Expand Down Expand Up @@ -154,7 +154,7 @@ int drm_ht_find_item(drm_open_hash_t *ht, unsigned long key,

list = drm_ht_find_key(ht, key);
if (!list)
return -1;
return -EINVAL;

*item = hlist_entry(list, drm_hash_item_t, head);
return 0;
Expand All @@ -170,7 +170,7 @@ int drm_ht_remove_key(drm_open_hash_t *ht, unsigned long key)
ht->fill--;
return 0;
}
return -1;
return -EINVAL;
}

int drm_ht_remove_item(drm_open_hash_t *ht, drm_hash_item_t *item)
Expand Down

0 comments on commit 47cc140

Please sign in to comment.