Skip to content

Commit

Permalink
printk, lockdep: Remove superfluous preempt_disable()
Browse files Browse the repository at this point in the history
The raw_lock_irq_{save,restore}() already implies a
non-preemptibility.

Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Peter Zijlstra authored and Ingo Molnar committed Nov 14, 2011
1 parent 94d24fc commit 47ff5c9
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions kernel/printk.c
Original file line number Diff line number Diff line change
Expand Up @@ -841,7 +841,6 @@ asmlinkage int vprintk(const char *fmt, va_list args)
boot_delay_msec();
printk_delay();

preempt_disable();
/* This stops the holder of console_sem just where we want him */
raw_local_irq_save(flags);
this_cpu = smp_processor_id();
Expand Down Expand Up @@ -965,7 +964,6 @@ asmlinkage int vprintk(const char *fmt, va_list args)
out_restore_irqs:
raw_local_irq_restore(flags);

preempt_enable();
return printed_len;
}
EXPORT_SYMBOL(printk);
Expand Down

0 comments on commit 47ff5c9

Please sign in to comment.