Skip to content

Commit

Permalink
staging: asus_oled: Remove superfluous loop
Browse files Browse the repository at this point in the history
This patch removes a superfluous loop in asus_oled.c
The code is equivalent to do{...} while (0) and thus executes the code
exactly once -> so we can simply remove the loop.

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Peter Huewe authored and Greg Kroah-Hartman committed Feb 29, 2012
1 parent 1ca7e78 commit 4804918
Showing 1 changed file with 8 additions and 11 deletions.
19 changes: 8 additions & 11 deletions drivers/staging/asus_oled/asus_oled.c
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,6 @@ static void setup_packet_header(struct asus_oled_packet *packet, char flags,

static void enable_oled(struct asus_oled_dev *odev, uint8_t enabl)
{
int a;
int retval;
int act_len;
struct asus_oled_packet *packet;
Expand All @@ -178,17 +177,15 @@ static void enable_oled(struct asus_oled_dev *odev, uint8_t enabl)
else
packet->bitmap[0] = 0xae;

for (a = 0; a < 1; a++) {
retval = usb_bulk_msg(odev->udev,
usb_sndbulkpipe(odev->udev, 2),
packet,
sizeof(struct asus_oled_header) + 1,
&act_len,
-1);
retval = usb_bulk_msg(odev->udev,
usb_sndbulkpipe(odev->udev, 2),
packet,
sizeof(struct asus_oled_header) + 1,
&act_len,
-1);

if (retval)
dev_dbg(&odev->udev->dev, "retval = %d\n", retval);
}
if (retval)
dev_dbg(&odev->udev->dev, "retval = %d\n", retval);

odev->enabled = enabl;

Expand Down

0 comments on commit 4804918

Please sign in to comment.