Skip to content

Commit

Permalink
Staging: hv: hv_mouse: clean up version structure usage
Browse files Browse the repository at this point in the history
Turns out no one uses the major or minor fields, but hey, we'll keep
them around just to make people feel happy...

Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Greg Kroah-Hartman committed Mar 3, 2011
1 parent cb2535a commit 480c28d
Showing 1 changed file with 11 additions and 13 deletions.
24 changes: 11 additions & 13 deletions drivers/staging/hv/hv_mouse.c
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,10 @@ struct mousevsc_drv_obj {
* Beta, RC < 2008/1/22 1,0
* RC > 2008/1/22 2,0
*/
#define SYNTHHID_INPUT_VERSION_MAJOR 2
#define SYNTHHID_INPUT_VERSION_MINOR 0
#define SYNTHHID_INPUT_VERSION_DWORD (SYNTHHID_INPUT_VERSION_MINOR | \
(SYNTHHID_INPUT_VERSION_MAJOR << 16))
#define SYNTHHID_INPUT_VERSION_MAJOR 2
#define SYNTHHID_INPUT_VERSION_MINOR 0
#define SYNTHHID_INPUT_VERSION (SYNTHHID_INPUT_VERSION_MINOR | \
(SYNTHHID_INPUT_VERSION_MAJOR << 16))


#pragma pack(push,1)
Expand Down Expand Up @@ -94,24 +94,23 @@ struct synthhid_msg {

union synthhid_version {
struct {
u16 Minor;
u16 Major;
u16 minor_version;
u16 major_version;
};

u32 AsDWord;
u32 version;
};

/*
* Protocol messages
*/
struct synthhid_protocol_request {
struct synthhid_msg_hdr header;
union synthhid_version VersionRequested;
union synthhid_version version_requested;
};

struct synthhid_protocol_response {
struct synthhid_msg_hdr header;
union synthhid_version VersionRequested;
union synthhid_version version_requested;
unsigned char Approved;
};

Expand Down Expand Up @@ -611,8 +610,7 @@ static int MousevscConnectToVsp(struct hv_device *Device)

request->u.Request.header.type = SynthHidProtocolRequest;
request->u.Request.header.size = sizeof(unsigned long);
request->u.Request.VersionRequested.AsDWord =
SYNTHHID_INPUT_VERSION_DWORD;
request->u.Request.version_requested.version = SYNTHHID_INPUT_VERSION;

pr_info("synthhid protocol request...");

Expand All @@ -639,7 +637,7 @@ static int MousevscConnectToVsp(struct hv_device *Device)

if (!response->u.Response.Approved) {
pr_err("synthhid protocol request failed (version %d)",
SYNTHHID_INPUT_VERSION_DWORD);
SYNTHHID_INPUT_VERSION);
ret = -1;
goto Cleanup;
}
Expand Down

0 comments on commit 480c28d

Please sign in to comment.