Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 214880
b: refs/heads/master
c: 042c53f
h: refs/heads/master
v: v3
  • Loading branch information
Christian Lamparter authored and John W. Linville committed Sep 28, 2010
1 parent 49d22c5 commit 4829728
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 41 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: b4c85d459c3a2c539a2d5885b12372e404bafc6b
refs/heads/master: 042c53f6e84896701b67012ad525bc44ea6de25f
1 change: 0 additions & 1 deletion trunk/drivers/net/wireless/ath/carl9170/carl9170.h
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,6 @@ struct ar9170 {
unsigned int tx_dropped;
unsigned int tx_ack_failures;
unsigned int tx_fcs_errors;
unsigned int tx_ampdu_timeout;
unsigned int rx_dropped;

/* EEPROM */
Expand Down
4 changes: 0 additions & 4 deletions trunk/drivers/net/wireless/ath/carl9170/debug.c
Original file line number Diff line number Diff line change
Expand Up @@ -798,8 +798,6 @@ DEBUGFS_READONLY_FILE(tx_total_queued, 20, "%d",
atomic_read(&ar->tx_total_queued));
DEBUGFS_READONLY_FILE(tx_ampdu_scheduler, 20, "%d",
atomic_read(&ar->tx_ampdu_scheduler));
DEBUGFS_READONLY_FILE(tx_ampdu_timeout, 20, "%d",
ar->tx_ampdu_timeout);

DEBUGFS_READONLY_FILE(tx_total_pending, 20, "%d",
atomic_read(&ar->tx_total_pending));
Expand Down Expand Up @@ -872,8 +870,6 @@ void carl9170_debugfs_register(struct ar9170 *ar)
DEBUGFS_ADD(ampdu_density);
DEBUGFS_ADD(ampdu_factor);

DEBUGFS_ADD(tx_ampdu_timeout);

DEBUGFS_ADD(tx_janitor_last_run);

DEBUGFS_ADD(tx_status_0);
Expand Down
37 changes: 2 additions & 35 deletions trunk/drivers/net/wireless/ath/carl9170/tx.c
Original file line number Diff line number Diff line change
Expand Up @@ -1042,41 +1042,8 @@ static void carl9170_tx_ampdu(struct ar9170 *ar)
queue = TID_TO_WME_AC(tid_info->tid);

spin_lock_bh(&tid_info->lock);
if (tid_info->state != CARL9170_TID_STATE_XMIT) {
first = skb_peek(&tid_info->queue);
if (first) {
struct ieee80211_tx_info *txinfo;
struct carl9170_tx_info *arinfo;

txinfo = IEEE80211_SKB_CB(first);
arinfo = (void *) txinfo->rate_driver_data;

if (time_is_after_jiffies(arinfo->timeout +
msecs_to_jiffies(CARL9170_QUEUE_TIMEOUT))
== true)
goto processed;

/*
* We've been waiting for the frame which
* matches "snx" (start sequence of the
* next aggregate) for some time now.
*
* But it never arrived. Therefore
* jump to the next available frame
* and kick-start the transmission.
*
* Note: This might induce odd latency
* spikes because the receiver will be
* waiting for the lost frame too.
*/
ar->tx_ampdu_timeout++;

tid_info->snx = carl9170_get_seq(first);
tid_info->state = CARL9170_TID_STATE_XMIT;
} else {
goto processed;
}
}
if (tid_info->state != CARL9170_TID_STATE_XMIT)
goto processed;

tid_info->counter++;
first = skb_peek(&tid_info->queue);
Expand Down

0 comments on commit 4829728

Please sign in to comment.