Skip to content

Commit

Permalink
drm/exynos: clean up machine compatible string check
Browse files Browse the repository at this point in the history
Use 'for' statemant instead of hard-coded 'if' statement.

Signed-off-by: Inki Dae <inki.dae@samsung.com>
  • Loading branch information
Inki Dae committed Nov 24, 2014
1 parent 820687b commit 4846e45
Showing 1 changed file with 15 additions and 3 deletions.
18 changes: 15 additions & 3 deletions drivers/gpu/drm/exynos/exynos_drm_drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -610,6 +610,12 @@ static int exynos_drm_platform_remove(struct platform_device *pdev)
return 0;
}

static const char * const strings[] = {
"samsung,exynos3",
"samsung,exynos4",
"samsung,exynos5",
};

static struct platform_driver exynos_drm_platform_driver = {
.probe = exynos_drm_platform_probe,
.remove = exynos_drm_platform_remove,
Expand All @@ -622,6 +628,7 @@ static struct platform_driver exynos_drm_platform_driver = {

static int exynos_drm_init(void)
{
bool is_exynos = false;
int ret, i, j;

/*
Expand All @@ -631,9 +638,14 @@ static int exynos_drm_init(void)
* by Exynos drm driver when using multi-platform kernel.
* So these codes will be replaced with more generic way later.
*/
if (!of_machine_is_compatible("samsung,exynos3") &&
!of_machine_is_compatible("samsung,exynos4") &&
!of_machine_is_compatible("samsung,exynos5"))
for (i = 0; i < ARRAY_SIZE(strings); i++) {
if (of_machine_is_compatible(strings[i])) {
is_exynos = true;
break;
}
}

if (!is_exynos)
return -ENODEV;

exynos_drm_pdev = platform_device_register_simple("exynos-drm", -1,
Expand Down

0 comments on commit 4846e45

Please sign in to comment.