Skip to content

Commit

Permalink
ASoC: rsnd: tidyup parameter assignment position
Browse files Browse the repository at this point in the history
84e9535("ASoC: rsnd: show debug message for SSI/SRC/DVC connection")
added debug message on rsnd_dai_connect(), but the relationship of
parameter check was absurdity. This patch tidyup it.
It is reported via Smatch/Dan

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Kuninori Morimoto authored and Mark Brown committed Jul 21, 2015
1 parent 70fb105 commit 48725e9
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions sound/soc/sh/rcar/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -332,12 +332,15 @@ u32 rsnd_get_dalign(struct rsnd_mod *mod, struct rsnd_dai_stream *io)
static int rsnd_dai_connect(struct rsnd_mod *mod,
struct rsnd_dai_stream *io)
{
struct rsnd_priv *priv = rsnd_mod_to_priv(mod);
struct device *dev = rsnd_priv_to_dev(priv);
struct rsnd_priv *priv;
struct device *dev;

if (!mod)
return -EIO;

priv = rsnd_mod_to_priv(mod);
dev = rsnd_priv_to_dev(priv);

io->mod[mod->type] = mod;

dev_dbg(dev, "%s[%d] is connected to io (%s)\n",
Expand Down

0 comments on commit 48725e9

Please sign in to comment.