Skip to content

Commit

Permalink
[media] stv0900: remove unnecessary null pointer check
Browse files Browse the repository at this point in the history
The address of a variable is impossible to be null, so we remove the check.

Signed-off-by: Cong Ding <dinggnu@gmail.com>
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Cong Ding authored and Mauro Carvalho Chehab committed Feb 8, 2013
1 parent a92591a commit 4880f56
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 15 deletions.
14 changes: 4 additions & 10 deletions drivers/media/dvb-frontends/stv0900_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -524,11 +524,8 @@ void stv0900_set_tuner(struct dvb_frontend *fe, u32 frequency,
struct dvb_frontend_ops *frontend_ops = NULL;
struct dvb_tuner_ops *tuner_ops = NULL;

if (&fe->ops)
frontend_ops = &fe->ops;

if (&frontend_ops->tuner_ops)
tuner_ops = &frontend_ops->tuner_ops;
frontend_ops = &fe->ops;
tuner_ops = &frontend_ops->tuner_ops;

if (tuner_ops->set_frequency) {
if ((tuner_ops->set_frequency(fe, frequency)) < 0)
Expand All @@ -552,11 +549,8 @@ void stv0900_set_bandwidth(struct dvb_frontend *fe, u32 bandwidth)
struct dvb_frontend_ops *frontend_ops = NULL;
struct dvb_tuner_ops *tuner_ops = NULL;

if (&fe->ops)
frontend_ops = &fe->ops;

if (&frontend_ops->tuner_ops)
tuner_ops = &frontend_ops->tuner_ops;
frontend_ops = &fe->ops;
tuner_ops = &frontend_ops->tuner_ops;

if (tuner_ops->set_bandwidth) {
if ((tuner_ops->set_bandwidth(fe, bandwidth)) < 0)
Expand Down
7 changes: 2 additions & 5 deletions drivers/media/dvb-frontends/stv0900_sw.c
Original file line number Diff line number Diff line change
Expand Up @@ -1167,11 +1167,8 @@ static u32 stv0900_get_tuner_freq(struct dvb_frontend *fe)
struct dvb_tuner_ops *tuner_ops = NULL;
u32 freq = 0;

if (&fe->ops)
frontend_ops = &fe->ops;

if (&frontend_ops->tuner_ops)
tuner_ops = &frontend_ops->tuner_ops;
frontend_ops = &fe->ops;
tuner_ops = &frontend_ops->tuner_ops;

if (tuner_ops->get_frequency) {
if ((tuner_ops->get_frequency(fe, &freq)) < 0)
Expand Down

0 comments on commit 4880f56

Please sign in to comment.