Skip to content

Commit

Permalink
[SCSI] ufs: fix potential NULL pointer dereferencing error in ufshcd_…
Browse files Browse the repository at this point in the history
…prove.

Avoid dereferencing a NULL pointer if scsi_host_alloc is failed.

Signed-off-by: Namjae Jeon <linkinjeon@gmail.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
  • Loading branch information
Namjae Jeon authored and James Bottomley committed May 23, 2012
1 parent 841f97b commit 4886b1a
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions drivers/scsi/ufs/ufshcd.c
Original file line number Diff line number Diff line change
Expand Up @@ -1836,7 +1836,7 @@ ufshcd_probe(struct pci_dev *pdev, const struct pci_device_id *id)
err = pci_request_regions(pdev, UFSHCD);
if (err < 0) {
dev_err(&pdev->dev, "request regions failed\n");
goto out_disable;
goto out_host_put;
}

hba->mmio_base = pci_ioremap_bar(pdev, 0);
Expand Down Expand Up @@ -1925,8 +1925,9 @@ ufshcd_probe(struct pci_dev *pdev, const struct pci_device_id *id)
iounmap(hba->mmio_base);
out_release_regions:
pci_release_regions(pdev);
out_disable:
out_host_put:
scsi_host_put(host);
out_disable:
pci_clear_master(pdev);
pci_disable_device(pdev);
out_error:
Expand Down

0 comments on commit 4886b1a

Please sign in to comment.