Skip to content

Commit

Permalink
remove detritus left by "mm: make read_cache_page synchronous"
Browse files Browse the repository at this point in the history
gets minix get_dir_page() in sync with its analogs; back in 2007
Nick has switched read_cache_page() and friends to sync behaviour
(i.e.  they wait for the page to get unlocked, check if it's uptodate
and if it isn't return ERR_PTR(-EIO) instead) and removed the
duplicate logics from the callers.  In case of fs/minix/dir.c he'd
removed only half of that...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
Al Viro committed May 28, 2010
1 parent 4c9002d commit 49837a8
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions fs/minix/dir.c
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,8 @@ static struct page * dir_get_page(struct inode *dir, unsigned long n)
{
struct address_space *mapping = dir->i_mapping;
struct page *page = read_mapping_page(mapping, n, NULL);
if (!IS_ERR(page)) {
if (!IS_ERR(page))
kmap(page);
if (!PageUptodate(page))
goto fail;
}
return page;

fail:
Expand Down

0 comments on commit 49837a8

Please sign in to comment.