Skip to content

Commit

Permalink
Revert "net: release skb->dst in sock_queue_rcv_skb()"
Browse files Browse the repository at this point in the history
This reverts commit 7035560.

As pointed out by Mark McLoughlin IP_PKTINFO cmsg data is one
post-queueing user, so this optimization is not valid right
now.

Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David S. Miller committed Dec 18, 2008
1 parent 3b5b35d commit 49ad959
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions net/core/sock.c
Original file line number Diff line number Diff line change
Expand Up @@ -289,11 +289,7 @@ int sock_queue_rcv_skb(struct sock *sk, struct sk_buff *skb)

skb->dev = NULL;
skb_set_owner_r(skb, sk);
/*
* release dst right now while its hot
*/
dst_release(skb->dst);
skb->dst = NULL;

/* Cache the SKB length before we tack it onto the receive
* queue. Once it is added it no longer belongs to us and
* may be freed by other threads of control pulling packets
Expand Down

0 comments on commit 49ad959

Please sign in to comment.