Skip to content

Commit

Permalink
block: use printk_once
Browse files Browse the repository at this point in the history
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Tim Waugh <tim@cyberelk.net>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
  • Loading branch information
Marcin Slusarz authored and Jens Axboe committed Sep 11, 2009
1 parent 212a502 commit 49b3a3c
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 20 deletions.
12 changes: 4 additions & 8 deletions drivers/block/paride/pcd.c
Original file line number Diff line number Diff line change
Expand Up @@ -219,8 +219,6 @@ static int pcd_sector; /* address of next requested sector */
static int pcd_count; /* number of blocks still to do */
static char *pcd_buf; /* buffer for request in progress */

static int pcd_warned; /* Have we logged a phase warning ? */

/* kernel glue structures */

static int pcd_block_open(struct block_device *bdev, fmode_t mode)
Expand Down Expand Up @@ -417,12 +415,10 @@ static int pcd_completion(struct pcd_unit *cd, char *buf, char *fun)
printk
("%s: %s: Unexpected phase %d, d=%d, k=%d\n",
cd->name, fun, p, d, k);
if ((verbose < 2) && !pcd_warned) {
pcd_warned = 1;
printk
("%s: WARNING: ATAPI phase errors\n",
cd->name);
}
if (verbose < 2)
printk_once(
"%s: WARNING: ATAPI phase errors\n",
cd->name);
mdelay(1);
}
if (k++ > PCD_TMO) {
Expand Down
4 changes: 1 addition & 3 deletions drivers/block/sx8.c
Original file line number Diff line number Diff line change
Expand Up @@ -1564,15 +1564,13 @@ static int carm_init_shm(struct carm_host *host)

static int carm_init_one (struct pci_dev *pdev, const struct pci_device_id *ent)
{
static unsigned int printed_version;
struct carm_host *host;
unsigned int pci_dac;
int rc;
struct request_queue *q;
unsigned int i;

if (!printed_version++)
printk(KERN_DEBUG DRV_NAME " version " DRV_VERSION "\n");
printk_once(KERN_DEBUG DRV_NAME " version " DRV_VERSION "\n");

rc = pci_enable_device(pdev);
if (rc)
Expand Down
12 changes: 3 additions & 9 deletions drivers/block/viodasd.c
Original file line number Diff line number Diff line change
Expand Up @@ -416,15 +416,9 @@ static int probe_disk(struct viodasd_device *d)
goto retry;
}
if (we.max_disk > (MAX_DISKNO - 1)) {
static int warned;

if (warned == 0) {
warned++;
printk(VIOD_KERN_INFO
"Only examining the first %d "
"of %d disks connected\n",
MAX_DISKNO, we.max_disk + 1);
}
printk_once(VIOD_KERN_INFO
"Only examining the first %d of %d disks connected\n",
MAX_DISKNO, we.max_disk + 1);
}

/* Send the close event to OS/400. We DON'T expect a response */
Expand Down

0 comments on commit 49b3a3c

Please sign in to comment.