Skip to content

Commit

Permalink
slub: Move map/flag clearing to __free_slab
Browse files Browse the repository at this point in the history
__free_slab does some diagnostics. The resetting of mapcount etc
in discard_slab() can interfere with debug processing. So move
the reset immediately before the page is freed.

Signed-off-by: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
  • Loading branch information
Christoph Lameter authored and Pekka Enberg committed Apr 14, 2008
1 parent 50ef37b commit 49bd522
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions mm/slub.c
Original file line number Diff line number Diff line change
Expand Up @@ -1125,6 +1125,8 @@ static void __free_slab(struct kmem_cache *s, struct page *page)
NR_SLAB_RECLAIMABLE : NR_SLAB_UNRECLAIMABLE,
-pages);

__ClearPageSlab(page);
reset_page_mapcount(page);
__free_pages(page, s->order);
}

Expand Down Expand Up @@ -1154,8 +1156,6 @@ static void discard_slab(struct kmem_cache *s, struct page *page)
struct kmem_cache_node *n = get_node(s, page_to_nid(page));

atomic_long_dec(&n->nr_slabs);
reset_page_mapcount(page);
__ClearPageSlab(page);
free_slab(s, page);
}

Expand Down

0 comments on commit 49bd522

Please sign in to comment.