Skip to content

Commit

Permalink
Btrfs: Fix setting umask when POSIX ACLs are not enabled
Browse files Browse the repository at this point in the history
We currently set sb->s_flags |= MS_POSIXACL unconditionally, which is
incorrect -- it tells the VFS that it shouldn't set umask because we
will, yet we don't set it ourselves if we aren't using POSIX ACLs, so
the umask ends up ignored.

Signed-off-by: Chris Ball <cjb@laptop.org>
Signed-off-by: Chris Mason <chris.mason@oracle.com>
  • Loading branch information
Chris Ball authored and Chris Mason committed Sep 29, 2009
1 parent 9ed74f2 commit 49cf6f4
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions fs/btrfs/super.c
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,9 @@ static int btrfs_fill_super(struct super_block *sb,
sb->s_export_op = &btrfs_export_ops;
sb->s_xattr = btrfs_xattr_handlers;
sb->s_time_gran = 1;
#ifdef CONFIG_BTRFS_POSIX_ACL
sb->s_flags |= MS_POSIXACL;
#endif

tree_root = open_ctree(sb, fs_devices, (char *)data);

Expand Down

0 comments on commit 49cf6f4

Please sign in to comment.