Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 295107
b: refs/heads/master
c: 48e971c
h: refs/heads/master
i:
  295105: 33f3c7f
  295103: 2372812
v: v3
  • Loading branch information
Guennadi Liakhovetski authored and Mauro Carvalho Chehab committed Mar 20, 2012
1 parent 28d9a9d commit 49e9b49
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 9 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 7705b6d8eac89067e5177835468c99e71e2cd40c
refs/heads/master: 48e971cd7fc2440d49159786ecc8786298f98cec
35 changes: 27 additions & 8 deletions trunk/drivers/media/video/sh_mobile_ceu_camera.c
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,10 @@ struct sh_mobile_ceu_dev {

u32 cflcr;

/* static max sizes either from platform data or default */
int max_width;
int max_height;

enum v4l2_field field;
int sequence;

Expand Down Expand Up @@ -1081,7 +1085,15 @@ static int sh_mobile_ceu_get_formats(struct soc_camera_device *icd, unsigned int
if (ret < 0)
return ret;

while ((mf.width > 2560 || mf.height > 1920) && shift < 4) {
/*
* All currently existing CEU implementations support 2560x1920
* or larger frames. If the sensor is proposing too big a frame,
* don't bother with possibly supportred by the CEU larger
* sizes, just try VGA multiples. If needed, this can be
* adjusted in the future.
*/
while ((mf.width > pcdev->max_width ||
mf.height > pcdev->max_height) && shift < 4) {
/* Try 2560x1920, 1280x960, 640x480, 320x240 */
mf.width = 2560 >> shift;
mf.height = 1920 >> shift;
Expand Down Expand Up @@ -1377,6 +1389,8 @@ static int client_s_crop(struct soc_camera_device *icd, struct v4l2_crop *crop,
static int client_s_fmt(struct soc_camera_device *icd,
struct v4l2_mbus_framefmt *mf, bool ceu_can_scale)
{
struct soc_camera_host *ici = to_soc_camera_host(icd->parent);
struct sh_mobile_ceu_dev *pcdev = ici->priv;
struct sh_mobile_ceu_cam *cam = icd->host_priv;
struct v4l2_subdev *sd = soc_camera_to_subdev(icd);
struct device *dev = icd->parent;
Expand Down Expand Up @@ -1410,8 +1424,8 @@ static int client_s_fmt(struct soc_camera_device *icd,
if (ret < 0)
return ret;

max_width = min(cap.bounds.width, 2560);
max_height = min(cap.bounds.height, 1920);
max_width = min(cap.bounds.width, pcdev->max_width);
max_height = min(cap.bounds.height, pcdev->max_height);

/* Camera set a format, but geometry is not precise, try to improve */
tmp_w = mf->width;
Expand Down Expand Up @@ -1551,7 +1565,7 @@ static int sh_mobile_ceu_set_crop(struct soc_camera_device *icd,
if (ret < 0)
return ret;

if (mf.width > 2560 || mf.height > 1920)
if (mf.width > pcdev->max_width || mf.height > pcdev->max_height)
return -EINVAL;

/* 4. Calculate camera scales */
Expand Down Expand Up @@ -1834,6 +1848,8 @@ static int sh_mobile_ceu_set_fmt(struct soc_camera_device *icd,
static int sh_mobile_ceu_try_fmt(struct soc_camera_device *icd,
struct v4l2_format *f)
{
struct soc_camera_host *ici = to_soc_camera_host(icd->parent);
struct sh_mobile_ceu_dev *pcdev = ici->priv;
const struct soc_camera_format_xlate *xlate;
struct v4l2_pix_format *pix = &f->fmt.pix;
struct v4l2_subdev *sd = soc_camera_to_subdev(icd);
Expand All @@ -1854,8 +1870,8 @@ static int sh_mobile_ceu_try_fmt(struct soc_camera_device *icd,
/* FIXME: calculate using depth and bus width */

/* CFSZR requires height and width to be 4-pixel aligned */
v4l_bound_align_image(&pix->width, 2, 2560, 2,
&pix->height, 4, 1920, 2, 0);
v4l_bound_align_image(&pix->width, 2, pcdev->max_width, 2,
&pix->height, 4, pcdev->max_height, 2, 0);

width = pix->width;
height = pix->height;
Expand Down Expand Up @@ -1890,8 +1906,8 @@ static int sh_mobile_ceu_try_fmt(struct soc_camera_device *icd,
* requested a bigger rectangle, it will not return a
* smaller one.
*/
mf.width = 2560;
mf.height = 1920;
mf.width = pcdev->max_width;
mf.height = pcdev->max_height;
ret = v4l2_device_call_until_err(sd->v4l2_dev,
soc_camera_grp_id(icd), video,
try_mbus_fmt, &mf);
Expand Down Expand Up @@ -2082,6 +2098,9 @@ static int __devinit sh_mobile_ceu_probe(struct platform_device *pdev)
goto exit_kfree;
}

pcdev->max_width = pcdev->pdata->max_width ? : 2560;
pcdev->max_height = pcdev->pdata->max_height ? : 1920;

base = ioremap_nocache(res->start, resource_size(res));
if (!base) {
err = -ENXIO;
Expand Down
2 changes: 2 additions & 0 deletions trunk/include/media/sh_mobile_ceu.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ struct sh_mobile_ceu_companion {

struct sh_mobile_ceu_info {
unsigned long flags;
int max_width;
int max_height;
struct sh_mobile_ceu_companion *csi2;
};

Expand Down

0 comments on commit 49e9b49

Please sign in to comment.