Skip to content

Commit

Permalink
Revert quicklist need->flush fix
Browse files Browse the repository at this point in the history
Did not fix the reported issue. Apart from other weirdness this causes a
bad link between the TLB flushing logic and the quicklists. If there is
indeed an issue that an arch needs a tlb flush before free then the arch
code needs to set tlb->need_flush before calling quicklist_free.

Signed-off-by: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Christoph Lameter authored and Linus Torvalds committed Dec 27, 2007
1 parent 11ee295 commit 49eaaa1
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions include/asm-generic/tlb.h
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,6 @@ tlb_flush_mmu(struct mmu_gather *tlb, unsigned long start, unsigned long end)
static inline void
tlb_finish_mmu(struct mmu_gather *tlb, unsigned long start, unsigned long end)
{
#ifdef CONFIG_QUICKLIST
tlb->need_flush += &__get_cpu_var(quicklist)[0].nr_pages != 0;
#endif
tlb_flush_mmu(tlb, start, end);

/* keep the page table cache within bounds */
Expand Down

0 comments on commit 49eaaa1

Please sign in to comment.