-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
coccinelle: semantic patch to check for PTR_ERR after reassignment
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Michal Marek <mmarek@suse.cz>
- Loading branch information
Julia Lawall
authored and
Michal Marek
committed
Feb 24, 2012
1 parent
47f67ea
commit 4a05f06
Showing
1 changed file
with
41 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
/// PTR_ERR should be applied before its argument is reassigned, typically | ||
/// to NULL | ||
/// | ||
// Confidence: High | ||
// Copyright: (C) 2012 Julia Lawall, INRIA/LIP6. GPLv2. | ||
// Copyright: (C) 2012 Gilles Muller, INRIA/LiP6. GPLv2. | ||
// URL: http://coccinelle.lip6.fr/ | ||
// Comments: | ||
// Options: -no_includes -include_headers | ||
|
||
virtual org | ||
virtual report | ||
virtual context | ||
|
||
@r exists@ | ||
expression e,e1; | ||
constant c; | ||
position p1,p2; | ||
@@ | ||
|
||
*e@p1 = c | ||
... when != e = e1 | ||
when != &e | ||
when != true IS_ERR(e) | ||
*PTR_ERR@p2(e) | ||
|
||
@script:python depends on org@ | ||
p1 << r.p1; | ||
p2 << r.p2; | ||
@@ | ||
cocci.print_main("PTR_ERR",p2) | ||
cocci.print_secs("assignment",p1) | ||
@script:python depends on report@ | ||
p1 << r.p1; | ||
p2 << r.p2; | ||
@@ | ||
msg = "ERROR: PTR_ERR applied after initialization to constant on line %s" % (p1[0].line) | ||
coccilib.report.print_report(p2[0],msg) |