Skip to content

Commit

Permalink
spi/pxa2xx: Use define for SSSR_TFL_MASK instead of plain numbers
Browse files Browse the repository at this point in the history
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Dirk Brandewie <dirk.brandewie@gmail.com>
  • Loading branch information
Sebastian Andrzej Siewior committed Dec 1, 2010
1 parent 49cbb1e commit 4a25605
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
3 changes: 2 additions & 1 deletion arch/arm/plat-pxa/include/plat/ssp.h
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,8 @@
#define SSSR_TFS (1 << 5) /* Transmit FIFO Service Request */
#define SSSR_RFS (1 << 6) /* Receive FIFO Service Request */
#define SSSR_ROR (1 << 7) /* Receive FIFO Overrun */

#define SSSR_TFL_MASK (0xf << 8) /* Transmit FIFO Level mask */
#define SSSR_RFL_MASK (0xf << 12) /* Receive FIFO Level mask */

/* extra bits in PXA255, PXA26x and PXA27x SSP ports */
#define SSCR0_TISSP (1 << 4) /* TI Sync Serial Protocol */
Expand Down
8 changes: 4 additions & 4 deletions drivers/spi/pxa2xx_spi.c
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ static int null_writer(struct driver_data *drv_data)
void __iomem *reg = drv_data->ioaddr;
u8 n_bytes = drv_data->n_bytes;

if (((read_SSSR(reg) & 0x00000f00) == 0x00000f00)
if (((read_SSSR(reg) & SSSR_TFL_MASK) == SSSR_TFL_MASK)
|| (drv_data->tx == drv_data->tx_end))
return 0;

Expand Down Expand Up @@ -252,7 +252,7 @@ static int u8_writer(struct driver_data *drv_data)
{
void __iomem *reg = drv_data->ioaddr;

if (((read_SSSR(reg) & 0x00000f00) == 0x00000f00)
if (((read_SSSR(reg) & SSSR_TFL_MASK) == SSSR_TFL_MASK)
|| (drv_data->tx == drv_data->tx_end))
return 0;

Expand All @@ -279,7 +279,7 @@ static int u16_writer(struct driver_data *drv_data)
{
void __iomem *reg = drv_data->ioaddr;

if (((read_SSSR(reg) & 0x00000f00) == 0x00000f00)
if (((read_SSSR(reg) & SSSR_TFL_MASK) == SSSR_TFL_MASK)
|| (drv_data->tx == drv_data->tx_end))
return 0;

Expand All @@ -306,7 +306,7 @@ static int u32_writer(struct driver_data *drv_data)
{
void __iomem *reg = drv_data->ioaddr;

if (((read_SSSR(reg) & 0x00000f00) == 0x00000f00)
if (((read_SSSR(reg) & SSSR_TFL_MASK) == SSSR_TFL_MASK)
|| (drv_data->tx == drv_data->tx_end))
return 0;

Expand Down

0 comments on commit 4a25605

Please sign in to comment.