Skip to content

Commit

Permalink
igb: don't read eicr when responding to legacy interrupts
Browse files Browse the repository at this point in the history
The interrupt handler was reading eicr and then doing nothing with the
result.  I have removed the variable and the register read since they
provide no value to the legacy interrupt handler.

Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Alexander Duyck authored and David S. Miller committed Feb 7, 2009
1 parent 28b0759 commit 4a3c643
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions drivers/net/igb/igb_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -3519,7 +3519,7 @@ static irqreturn_t igb_intr_msi(int irq, void *data)
}

/**
* igb_intr - Interrupt Handler
* igb_intr - Legacy Interrupt Handler
* @irq: interrupt number
* @data: pointer to a network interface device structure
**/
Expand All @@ -3531,7 +3531,6 @@ static irqreturn_t igb_intr(int irq, void *data)
/* Interrupt Auto-Mask...upon reading ICR, interrupts are masked. No
* need for the IMC write */
u32 icr = rd32(E1000_ICR);
u32 eicr = 0;
if (!icr)
return IRQ_NONE; /* Not our interrupt */

Expand All @@ -3547,8 +3546,6 @@ static irqreturn_t igb_intr(int irq, void *data)
adapter->stats.doosync++;
}

eicr = rd32(E1000_EICR);

if (icr & (E1000_ICR_RXSEQ | E1000_ICR_LSC)) {
hw->mac.get_link_status = 1;
/* guard against interrupt when we're going down */
Expand Down

0 comments on commit 4a3c643

Please sign in to comment.