Skip to content

Commit

Permalink
i386: simplify smp_call_function_single() call sequence in cpuid
Browse files Browse the repository at this point in the history
smp_call_function_single() now knows how to call the function on the
current cpu.

[ tglx: arch/x86 adaptation ]

Cc: H. Peter Anvin <hpa@zytor.com>
Signed-off-by: Avi Kivity <avi@qumranet.com>
Signed-off-by: Andi Kleen <ak@suse.de>
Cc: Andi Kleen <ak@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Avi Kivity authored and Thomas Gleixner committed Oct 17, 2007
1 parent cddf7ff commit 4a40cb1
Showing 1 changed file with 3 additions and 19 deletions.
22 changes: 3 additions & 19 deletions arch/x86/kernel/cpuid.c
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@

static struct class *cpuid_class;

#ifdef CONFIG_SMP

struct cpuid_command {
u32 reg;
u32 *data;
Expand All @@ -62,25 +60,11 @@ static inline void do_cpuid(int cpu, u32 reg, u32 * data)
{
struct cpuid_command cmd;

preempt_disable();
if (cpu == smp_processor_id()) {
cpuid(reg, &data[0], &data[1], &data[2], &data[3]);
} else {
cmd.reg = reg;
cmd.data = data;
cmd.reg = reg;
cmd.data = data;

smp_call_function_single(cpu, cpuid_smp_cpuid, &cmd, 1, 1);
}
preempt_enable();
smp_call_function_single(cpu, cpuid_smp_cpuid, &cmd, 1, 1);
}
#else /* ! CONFIG_SMP */

static inline void do_cpuid(int cpu, u32 reg, u32 * data)
{
cpuid(reg, &data[0], &data[1], &data[2], &data[3]);
}

#endif /* ! CONFIG_SMP */

static loff_t cpuid_seek(struct file *file, loff_t offset, int orig)
{
Expand Down

0 comments on commit 4a40cb1

Please sign in to comment.