Skip to content

Commit

Permalink
V4L/DVB (12527): tw9910: do not lie about cropping abilities
Browse files Browse the repository at this point in the history
The current tw9910 driver does not implement cropping correctly. Therefore, and
also because various rectangles in struct soc_camera_device are in user scale,
we cannot and shall not use rect_current as window location.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Guennadi Liakhovetski authored and Mauro Carvalho Chehab committed Sep 19, 2009
1 parent 9489629 commit 4a5a5b2
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions drivers/media/video/tw9910.c
Original file line number Diff line number Diff line change
Expand Up @@ -719,9 +719,10 @@ static int tw9910_s_fmt(struct v4l2_subdev *sd, struct v4l2_format *f)
struct i2c_client *client = sd->priv;
struct soc_camera_device *icd = client->dev.platform_data;
struct v4l2_pix_format *pix = &f->fmt.pix;
/* See tw9910_set_crop() - no proper cropping support */
struct v4l2_rect rect = {
.left = icd->rect_current.left,
.top = icd->rect_current.top,
.left = 0,
.top = 0,
.width = pix->width,
.height = pix->height,
};
Expand Down Expand Up @@ -850,6 +851,7 @@ static struct v4l2_subdev_ops tw9910_subdev_ops = {
* i2c_driver function
*/

/* This is called during probe, so, setting rect_max is Ok here: scale == 1 */
static void limit_to_scale(struct soc_camera_device *icd,
const struct tw9910_scale_ctrl *scale)
{
Expand Down

0 comments on commit 4a5a5b2

Please sign in to comment.