Skip to content

Commit

Permalink
x86: pageattr-test: remove srandom32 call
Browse files Browse the repository at this point in the history
pageattr-test calls srandom32() once every test iteration.  But calling
srandom32() after late_initcalls is not meaningfull.  Because the random
states for random32() is mixed by good random numbers in late_initcall
prandom_reseed().

So this removes the call to srandom32().

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Acked-by: H. Peter Anvin <hpa@zytor.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Akinobu Mita authored and Linus Torvalds committed Apr 30, 2013
1 parent cedddb0 commit 4a7b4d2
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion arch/x86/mm/pageattr-test.c
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,6 @@ static int pageattr_test(void)
}

failed += print_split(&sa);
srandom32(100);

for (i = 0; i < NTEST; i++) {
unsigned long pfn = random32() % max_pfn_mapped;
Expand Down

0 comments on commit 4a7b4d2

Please sign in to comment.