Skip to content

Commit

Permalink
Revert task flag re-ordering, add comments
Browse files Browse the repository at this point in the history
Roland points out that the flags end up having non-obvious dependencies
elsewhere, so revert aa55a08 and add
some comments about why things are as they are.

We'll just have to fix up the broken comparisons. Roland has a patch.

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Linus Torvalds committed Sep 29, 2005
1 parent aa55a08 commit 4a8342d
Showing 1 changed file with 17 additions and 5 deletions.
22 changes: 17 additions & 5 deletions include/linux/sched.h
Original file line number Diff line number Diff line change
Expand Up @@ -107,14 +107,26 @@ extern unsigned long nr_iowait(void);

#include <asm/processor.h>

/*
* Task state bitmask. NOTE! These bits are also
* encoded in fs/proc/array.c: get_task_state().
*
* We have two separate sets of flags: task->state
* is about runnability, while task->exit_state are
* about the task exiting. Confusing, but this way
* modifying one set can't modify the other one by
* mistake.
*/
#define TASK_RUNNING 0
#define TASK_INTERRUPTIBLE 1
#define TASK_UNINTERRUPTIBLE 2
#define TASK_NONINTERACTIVE 4
#define TASK_STOPPED 8
#define TASK_TRACED 16
#define EXIT_ZOMBIE 32
#define EXIT_DEAD 64
#define TASK_STOPPED 4
#define TASK_TRACED 8
/* in tsk->exit_state */
#define EXIT_ZOMBIE 16
#define EXIT_DEAD 32
/* in tsk->state again */
#define TASK_NONINTERACTIVE 64

#define __set_task_state(tsk, state_value) \
do { (tsk)->state = (state_value); } while (0)
Expand Down

0 comments on commit 4a8342d

Please sign in to comment.