Skip to content

Commit

Permalink
pcmcia/bfin_cf: don't check platform_get_irq's return value against zero
Browse files Browse the repository at this point in the history
platform_get_irq returns -ENXIO on failure, so !irq was probably
always true.  Better use irq <= 0.  Note that a return value of
zero is still handled as error even though this could mean irq0.

This is a followup to 305b322 that
changed the return value of platform_get_irq from 0 to -ENXIO on error.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: David Vrabel <dvrabel@arcom.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Cc: Rafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
  • Loading branch information
Uwe Kleine-König authored and Dominik Brodowski committed Feb 17, 2010
1 parent 3516952 commit 4aa50bc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/pcmcia/bfin_cf_pcmcia.c
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ static int __devinit bfin_cf_probe(struct platform_device *pdev)
dev_info(&pdev->dev, "Blackfin CompactFlash/PCMCIA Socket Driver\n");

irq = platform_get_irq(pdev, 0);
if (!irq)
if (irq <= 0)
return -EINVAL;

cd_pfx = platform_get_irq(pdev, 1); /*Card Detect GPIO PIN */
Expand Down

0 comments on commit 4aa50bc

Please sign in to comment.