---

yaml --- r: 30921 b: refs/heads/master c: 97dfd70 h: refs/heads/master i: 30919: 4900892 v: v3
git-mirror · Jun 27, 2006 · 4ade9f5 · 4ade9f5
1 parent 768cd7b
commit 4ade9f5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/[refs] b/[refs]
@@ -1,2 +1,2 @@
 ---
-refs/heads/master: 05a3332885dd143496694bcecff223339880d7c9
+refs/heads/master: 97dfd70c8958a634157e0b35711cca01ff6f959b
diff --git a/trunk/fs/xfs/linux-2.6/xfs_iops.c b/trunk/fs/xfs/linux-2.6/xfs_iops.c
@@ -422,10 +422,12 @@ xfs_vn_link(
 	tdvp = vn_from_inode(dir);
 	vp = vn_from_inode(ip);
 
+	VN_HOLD(vp);
 	error = bhv_vop_link(tdvp, vp, dentry, NULL);
-	if (likely(!error)) {
+	if (unlikely(error)) {
+		VN_RELE(vp);
+	} else {
 		VMODIFY(tdvp);
-		VN_HOLD(vp);
 		xfs_validate_fields(ip, &vattr);
 		d_instantiate(dentry, ip);
 	}