Skip to content

Commit

Permalink
drm/rcar-du: use for_each_endpoint_of_node macro
Browse files Browse the repository at this point in the history
Using the for_each_... macro should make the code a bit shorter and
easier to read.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
  • Loading branch information
Philipp Zabel committed Apr 8, 2015
1 parent 539bb6a commit 4af642d
Showing 1 changed file with 3 additions and 13 deletions.
16 changes: 3 additions & 13 deletions drivers/gpu/drm/rcar-du/rcar_du_kms.c
Original file line number Diff line number Diff line change
Expand Up @@ -224,12 +224,7 @@ static int rcar_du_encoders_init_one(struct rcar_du_device *rcdu,

entity_ep_node = of_parse_phandle(ep->local_node, "remote-endpoint", 0);

while (1) {
ep_node = of_graph_get_next_endpoint(entity, ep_node);

if (!ep_node)
break;

for_each_endpoint_of_node(entity, ep_node) {
if (ep_node == entity_ep_node)
continue;

Expand Down Expand Up @@ -296,24 +291,19 @@ static int rcar_du_encoders_init_one(struct rcar_du_device *rcdu,
static int rcar_du_encoders_init(struct rcar_du_device *rcdu)
{
struct device_node *np = rcdu->dev->of_node;
struct device_node *ep_node = NULL;
struct device_node *ep_node;
unsigned int num_encoders = 0;

/*
* Iterate over the endpoints and create one encoder for each output
* pipeline.
*/
while (1) {
for_each_endpoint_of_node(np, ep_node) {
enum rcar_du_output output;
struct of_endpoint ep;
unsigned int i;
int ret;

ep_node = of_graph_get_next_endpoint(np, ep_node);

if (ep_node == NULL)
break;

ret = of_graph_parse_endpoint(ep_node, &ep);
if (ret < 0) {
of_node_put(ep_node);
Expand Down

0 comments on commit 4af642d

Please sign in to comment.