Skip to content

Commit

Permalink
[PATCH] cleanup of deadline_dispatch_requests()
Browse files Browse the repository at this point in the history
cleanup of deadline_dispatch_requests():

- replace drq selection with hopefully clearer while semantically the
  same construct: take write request, if there is any, otherwise take read
  one, or NULL if none exist.

- kill unused other_dir.

Signed-off-by: Nikita Danilov <nikita@clusterfs.com>
Cc: Jens Axboe <axboe@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Nikita Danilov authored and Linus Torvalds committed Sep 7, 2005
1 parent ffdfc40 commit 4b0dc07
Showing 1 changed file with 2 additions and 10 deletions.
12 changes: 2 additions & 10 deletions drivers/block/deadline-iosched.c
Original file line number Diff line number Diff line change
Expand Up @@ -507,18 +507,12 @@ static int deadline_dispatch_requests(struct deadline_data *dd)
const int reads = !list_empty(&dd->fifo_list[READ]);
const int writes = !list_empty(&dd->fifo_list[WRITE]);
struct deadline_rq *drq;
int data_dir, other_dir;
int data_dir;

/*
* batches are currently reads XOR writes
*/
drq = NULL;

if (dd->next_drq[READ])
drq = dd->next_drq[READ];

if (dd->next_drq[WRITE])
drq = dd->next_drq[WRITE];
drq = dd->next_drq[WRITE] ? : dd->next_drq[READ];

if (drq) {
/* we have a "next request" */
Expand All @@ -544,7 +538,6 @@ static int deadline_dispatch_requests(struct deadline_data *dd)
goto dispatch_writes;

data_dir = READ;
other_dir = WRITE;

goto dispatch_find_request;
}
Expand All @@ -560,7 +553,6 @@ static int deadline_dispatch_requests(struct deadline_data *dd)
dd->starved = 0;

data_dir = WRITE;
other_dir = READ;

goto dispatch_find_request;
}
Expand Down

0 comments on commit 4b0dc07

Please sign in to comment.