Skip to content

Commit

Permalink
quota: make Q_XQUOTASYNC a noop
Browse files Browse the repository at this point in the history
Now that XFS takes quota reservations into account there is no need to flush
anything before reporting quotas - in addition to beeing fully transactional
all quota information is also 100% coherent with the rest of the filesystem
now.

Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ben Myers <bpm@sgi.com>
  • Loading branch information
Christoph Hellwig authored and Ben Myers committed Feb 29, 2012
1 parent 8960501 commit 4b217ed
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions fs/quota/quota.c
Original file line number Diff line number Diff line change
Expand Up @@ -282,10 +282,9 @@ static int do_quotactl(struct super_block *sb, int type, int cmd, qid_t id,
case Q_XGETQUOTA:
return quota_getxquota(sb, type, id, addr);
case Q_XQUOTASYNC:
/* caller already holds s_umount */
if (sb->s_flags & MS_RDONLY)
return -EROFS;
writeback_inodes_sb(sb, WB_REASON_SYNC);
/* XFS quotas are fully coherent now, making this call a noop */
return 0;
default:
return -EINVAL;
Expand Down

0 comments on commit 4b217ed

Please sign in to comment.