Skip to content

Commit

Permalink
oss: fix O_NONBLOCK in dmasound_core
Browse files Browse the repository at this point in the history
We broke O_NONBLOCK handling in OSS dmasound_core in 2.3.11-pre3 - the
original code copied f_flags to open_mode and then checked for
O_NONBLOCK in there, but that got changed to copying f_mode and
O_NONBLOCK has not reached that field in any kernel version.

Since we do not care for any other bits, the fix is obvious...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Al Viro authored and Linus Torvalds committed Nov 1, 2008
1 parent 67d1128 commit 4b30fbd
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion sound/oss/dmasound/dmasound.h
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ struct sound_queue {
*/
int active;
wait_queue_head_t action_queue, open_queue, sync_queue;
fmode_t open_mode;
int non_blocking;
int busy, syncing, xruns, died;
};

Expand Down
4 changes: 2 additions & 2 deletions sound/oss/dmasound/dmasound_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -603,7 +603,7 @@ static ssize_t sq_write(struct file *file, const char __user *src, size_t uLeft,
while (uLeft) {
while (write_sq.count >= write_sq.max_active) {
sq_play();
if (write_sq.open_mode & O_NONBLOCK)
if (write_sq.non_blocking)
return uWritten > 0 ? uWritten : -EAGAIN;
SLEEP(write_sq.action_queue);
if (signal_pending(current))
Expand Down Expand Up @@ -718,7 +718,7 @@ static int sq_open2(struct sound_queue *sq, struct file *file, fmode_t mode,
return rc;
}

sq->open_mode = file->f_mode;
sq->non_blocking = file->f_flags & O_NONBLOCK;
}
return rc;
}
Expand Down

0 comments on commit 4b30fbd

Please sign in to comment.