Skip to content

Commit

Permalink
net: fix dev_set_promiscuity() breakage
Browse files Browse the repository at this point in the history
Commit dad9b33 (netdevice: Fix promiscuity and allmulti overflow) broke
dev_set_promiscuity() by returning on success without reprogramming the
device.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Patrick McHardy authored and David S. Miller committed Jul 6, 2008
1 parent fb0305c commit 4b5a698
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/core/dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -2859,7 +2859,7 @@ int dev_set_promiscuity(struct net_device *dev, int inc)
int err;

err = __dev_set_promiscuity(dev, inc);
if (!err)
if (err < 0)
return err;
if (dev->flags != old_flags)
dev_set_rx_mode(dev);
Expand Down

0 comments on commit 4b5a698

Please sign in to comment.