Skip to content

Commit

Permalink
[SPARC64]: Fix of_device bus_id settings.
Browse files Browse the repository at this point in the history
They have to be unique system-wide, so use
"NAME@NODE" as the string pattern of the non-root
nodes.

Thanks to Andrew Morton for fixing the error value
checking in bus_add_device() which made this problem
finally noticable.

Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David S. Miller committed Oct 10, 2006
1 parent 99ae1c8 commit 4b75eb2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/sparc64/kernel/of_device.c
Original file line number Diff line number Diff line change
Expand Up @@ -841,7 +841,7 @@ static struct of_device * __init scan_one_device(struct device_node *dp,
if (!parent)
strcpy(op->dev.bus_id, "root");
else
strcpy(op->dev.bus_id, dp->path_component_name);
sprintf(op->dev.bus_id, "%s@%08x", dp->name, dp->node);

if (of_device_register(op)) {
printk("%s: Could not register of device.\n",
Expand Down

0 comments on commit 4b75eb2

Please sign in to comment.